From: Petr Viktorin <encukou@gmail.com>
Date: Wed, 23 Aug 2023 18:00:07 +0000 (+0200)
Subject: gh-107811: tarfile: treat overflow in UID/GID as failure to set it (#108369)
X-Git-Tag: v3.13.0a1~827
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=5d1871576500adc4ebaa7f59b8559605a57ad36b;p=thirdparty%2FPython%2Fcpython.git

gh-107811: tarfile: treat overflow in UID/GID as failure to set it (#108369)
---

diff --git a/Lib/tarfile.py b/Lib/tarfile.py
index a835d00c90c9..726f9f50ba2e 100755
--- a/Lib/tarfile.py
+++ b/Lib/tarfile.py
@@ -2557,7 +2557,8 @@ class TarFile(object):
                     os.lchown(targetpath, u, g)
                 else:
                     os.chown(targetpath, u, g)
-            except OSError as e:
+            except (OSError, OverflowError) as e:
+                # OverflowError can be raised if an ID doesn't fit in `id_t`
                 raise ExtractError("could not change owner") from e
 
     def chmod(self, tarinfo, targetpath):
diff --git a/Misc/NEWS.d/next/Library/2023-08-23-17-34-39.gh-issue-107811.3Fng72.rst b/Misc/NEWS.d/next/Library/2023-08-23-17-34-39.gh-issue-107811.3Fng72.rst
new file mode 100644
index 000000000000..ffca4131db22
--- /dev/null
+++ b/Misc/NEWS.d/next/Library/2023-08-23-17-34-39.gh-issue-107811.3Fng72.rst
@@ -0,0 +1,3 @@
+:mod:`tarfile`: extraction of members with overly large UID or GID (e.g. on
+an OS with 32-bit :c:type:`!id_t`) now fails in the same way as failing to
+set the ID.