From: Havoc Pennington Date: Wed, 14 Jun 2006 04:16:30 +0000 (+0000) Subject: add dbus_bus_get refcount item to TODO X-Git-Tag: dbus-0.90~17 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=5db59894bbb8a921a528552c99136e763bf676f0;p=thirdparty%2Fdbus.git add dbus_bus_get refcount item to TODO link to mail list post about pending call threading problems --- diff --git a/doc/TODO b/doc/TODO index 1f70e859d..1b75985bd 100644 --- a/doc/TODO +++ b/doc/TODO @@ -21,7 +21,12 @@ Important for 1.0 - just before 1.0, try a HAVE_INT64=0 build and be sure it runs - - dbus-pending-call.c has some API and thread safety issues to review + - dbus-pending-call.c has some API and thread safety issues to review. + DBusPendingCall is used from multiple threads with no locks. + Either DBusConnection's lock has to protect all associated pending + call (means pending->connection can't ever be set to null) or + or DBusPendingCall needs its own lock + http://lists.freedesktop.org/archives/dbus/2006-June/004945.html - Add test harness for selinux allow/deny cf. this message http://lists.freedesktop.org/archives/dbus/2005-April/002506.html @@ -35,6 +40,11 @@ Important for 1.0 Kind of a major API change, but seems high-value. + - dbus_bus_get() should hold a strong reference associated with the "connected" + state (i.e. libdbus drops its reference when the connection disconnects, + and sets its internal connection variable to null). + See http://lists.freedesktop.org/archives/dbus/2006-May/004806.html + Important for 1.0 GLib Bindings ===