From: Nick Mathewson <nickm@torproject.org>
Date: Mon, 3 Feb 2020 18:36:56 +0000 (-0500)
Subject: practracker: use shutil.move so --regen will work on windows
X-Git-Tag: tor-0.4.3.2-alpha~10^2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=5e963f97b1e70012e0917ce160b1579a87ab9bcb;p=thirdparty%2Ftor.git

practracker: use shutil.move so --regen will work on windows

On windows you can't os.rename() a file if the target filename
already exists.
---

diff --git a/scripts/maint/practracker/practracker.py b/scripts/maint/practracker/practracker.py
index 3f40f63c48..6149fb79cb 100755
--- a/scripts/maint/practracker/practracker.py
+++ b/scripts/maint/practracker/practracker.py
@@ -30,6 +30,7 @@ import metrics
 import util
 import problem
 import includes
+import shutil
 
 # The filename of the exceptions file (it should be placed in the practracker directory)
 EXCEPTIONS_FNAME = "./exceptions.txt"
@@ -275,7 +276,7 @@ def main(argv):
 
     if args.regen:
         tmpfile.close()
-        os.rename(tmpname, exceptions_file)
+        shutil.move(tmpname, exceptions_file)
         sys.exit(0)
 
     if args.regen_overbroad:
@@ -285,7 +286,7 @@ def main(argv):
         for item in ProblemVault.list_exceptions_without_overbroad():
             print(item, file=tmpfile)
         tmpfile.close()
-        os.rename(tmpname, exceptions_file)
+        shutil.move(tmpname, exceptions_file)
         sys.exit(0)
 
     # If new issues were found, try to give out some advice to the developer on how to resolve it.