From: Günther Deschner <gd@samba.org>
Date: Thu, 6 Mar 2008 19:44:28 +0000 (+0100)
Subject: Fix _dssetup_DsRoleGetPrimaryDomainInformation().
X-Git-Tag: samba-3.3.0pre1~3405
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=5eb7b7a9db4bda40660df5ab67bfea99e75716f9;p=thirdparty%2Fsamba.git

Fix _dssetup_DsRoleGetPrimaryDomainInformation().

Guenther
---

diff --git a/source/rpc_server/srv_dssetup_nt.c b/source/rpc_server/srv_dssetup_nt.c
index ea535a33759..2b18e6b2aeb 100644
--- a/source/rpc_server/srv_dssetup_nt.c
+++ b/source/rpc_server/srv_dssetup_nt.c
@@ -35,7 +35,7 @@ static WERROR fill_dsrole_dominfo_basic(TALLOC_CTX *ctx,
 					struct dssetup_DsRolePrimaryDomInfoBasic **info)
 {
 	struct dssetup_DsRolePrimaryDomInfoBasic *basic = NULL;
-	fstring dnsdomain;
+	char *dnsdomain = NULL;
 
 	DEBUG(10,("fill_dsrole_dominfo_basic: enter\n"));
 
@@ -71,7 +71,10 @@ static WERROR fill_dsrole_dominfo_basic(TALLOC_CTX *ctx,
 	/* fill in some additional fields if we are a member of an AD domain */
 
 	if (lp_security() == SEC_ADS) {
-		fstrcpy(dnsdomain, lp_realm());
+		dnsdomain = talloc_strdup(ctx, lp_realm());
+		if (!dnsdomain) {
+			return WERR_NOMEM;
+		}
 		strlower_m(dnsdomain);
 		basic->dns_domain = dnsdomain;