From: Jo Sutton <josutton@catalyst.net.nz>
Date: Thu, 18 Apr 2024 00:47:28 +0000 (+1200)
Subject: ldb: Check result of py_ldb_msg_keys()
X-Git-Tag: tdb-1.4.11~1073
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=5eea17a71bd69f39226a32725a0b09b60dd5308c;p=thirdparty%2Fsamba.git

ldb: Check result of py_ldb_msg_keys()

Passing NULL into PyObject_GetIter() can cause a segmentation fault.

Signed-off-by: Jo Sutton <josutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/lib/ldb/pyldb.c b/lib/ldb/pyldb.c
index f416bfe6d5d..d54a952ac01 100644
--- a/lib/ldb/pyldb.c
+++ b/lib/ldb/pyldb.c
@@ -4143,6 +4143,9 @@ static PyObject *py_ldb_msg_iter(PyObject *self)
 	PyObject *list, *iter;
 
 	list = py_ldb_msg_keys(self, NULL);
+	if (list == NULL) {
+		return NULL;
+	}
 	iter = PyObject_GetIter(list);
 	Py_DECREF(list);
 	return iter;