From: Amos Jeffries <squid3@treenet.co.nz>
Date: Thu, 11 Sep 2008 11:19:43 +0000 (+1200)
Subject: Bug 2454: IPFWInterception getsockname() test is inverted
X-Git-Tag: SQUID_3_1_0_1~49^2~49
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=5ef9857ef66773c272f8855780b5ec8dcd7be2fd;p=thirdparty%2Fsquid.git

Bug 2454: IPFWInterception getsockname() test is inverted
---

diff --git a/src/IPInterception.cc b/src/IPInterception.cc
index 2c493248cf..3615988694 100644
--- a/src/IPInterception.cc
+++ b/src/IPInterception.cc
@@ -198,7 +198,7 @@ IPIntercept::IPFWInterception(int fd, const IPAddress &me, IPAddress &dst, int s
 
     /** \par
      * Try lookup for IPFW interception. */
-    if( getsockname(fd, lookup->ai_addr, &lookup->ai_addrlen) >= 0 ) {
+    if( getsockname(fd, lookup->ai_addr, &lookup->ai_addrlen) != 0 ) {
         if( !silent ) {
             debugs(89, DBG_IMPORTANT, HERE << " IPFW getsockname(...) failed: " << xstrerror());
             last_reported = squid_curtime;