From: Volker Lendecke <vl@samba.org>
Date: Fri, 8 Dec 2017 16:21:37 +0000 (+0100)
Subject: messaging: Ignore messages from ourselves
X-Git-Tag: talloc-2.1.11~253
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=5f31c911d1149a74f942292c623e8b213c587758;p=thirdparty%2Fsamba.git

messaging: Ignore messages from ourselves

For non-clustered messaging this should have never gone through the socket, we
should have caught it before in messaging_send_iov_from.

It can come in on a socket from ctdb when broadcasting in clustered mode. There
ctdb does the broadcasting.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
---

diff --git a/source3/lib/messages.c b/source3/lib/messages.c
index 561616df6e4..464233fda2c 100644
--- a/source3/lib/messages.c
+++ b/source3/lib/messages.c
@@ -399,6 +399,11 @@ static void messaging_recv_cb(struct tevent_context *ev,
 		  (unsigned)rec.msg_type, rec.buf.length, num_fds,
 		  server_id_str_buf(rec.src, &idbuf));
 
+	if (server_id_same_process(&rec.src, &msg_ctx->id)) {
+		DBG_DEBUG("Ignoring self-send\n");
+		goto close_fail;
+	}
+
 	messaging_dispatch_rec(msg_ctx, ev, &rec);
 	return;