From: Timo Sirainen <tss@iki.fi>
Date: Tue, 14 Sep 2010 20:12:08 +0000 (+0100)
Subject: lib-index: day_first_uid[] array wasn't kept properly up to date.
X-Git-Tag: 2.0.3~12
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=5f43b6def0e57b0800668e5d5a9821b49d1c1843;p=thirdparty%2Fdovecot%2Fcore.git

lib-index: day_first_uid[] array wasn't kept properly up to date.
The result was that caching decisions could have been sometimes slightly wrong.
Based on patch by Paul E. Black.
---

diff --git a/src/lib-index/mail-index-transaction-update.c b/src/lib-index/mail-index-transaction-update.c
index 3d4312190f..02afedff6d 100644
--- a/src/lib-index/mail-index-transaction-update.c
+++ b/src/lib-index/mail-index-transaction-update.c
@@ -143,7 +143,8 @@ void mail_index_update_day_headers(struct mail_index_transaction *t)
 
 	/* @UNSAFE: move days forward and fill the missing days with old
 	   day_first_uid[0]. */
-	memmove(hdr.day_first_uid + days, hdr.day_first_uid, max_days - days);
+	memmove(hdr.day_first_uid + days, hdr.day_first_uid,
+		(max_days - days) * sizeof(hdr.day_first_uid[0]));
 	for (i = 1; i < days; i++)
 		hdr.day_first_uid[i] = hdr.day_first_uid[0];