From: Volker Lendecke <vl@samba.org>
Date: Sun, 23 Mar 2008 16:57:01 +0000 (+0100)
Subject: Fix Coverity ID 478
X-Git-Tag: samba-3.3.0pre1~3145
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=5f77938dc4a280b654b8d08656f19a7d04cea8c7;p=thirdparty%2Fsamba.git

Fix Coverity ID 478
---

diff --git a/source/registry/reg_backend_printing.c b/source/registry/reg_backend_printing.c
index 582989d8d16..b2cd5537068 100644
--- a/source/registry/reg_backend_printing.c
+++ b/source/registry/reg_backend_printing.c
@@ -516,8 +516,7 @@ static int key_printers_fetch_values( const char *key, REGVAL_CTR *values )
 	if ( (key_index = lookup_printerkey( p_data, printerdatakey )) == -1  ) {
 		/* failure....should never happen if the client has a valid open handle first */
 		DEBUG(10,("key_printers_fetch_values: Unknown keyname [%s]\n", printerdatakey));
-		if ( printer )
-			free_a_printer( &printer, 2 );
+		free_a_printer( &printer, 2 );
 		return -1;
 	}