From: Paulo Neves <ptsneves@gmail.com>
Date: Sun, 3 Jul 2022 11:41:13 +0000 (+0200)
Subject: oeqa/sysroot.py: Check bitbake return status
X-Git-Tag: lucaceresoli/bug-15201-perf-libtraceevent-missing~3699
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=5fe8c14f50d414e768588cef0675d8ef296ced77;p=thirdparty%2Fopenembedded%2Fopenembedded-core-contrib.git

oeqa/sysroot.py: Check bitbake return status

bitbake ran but we incorrectly did not assert the exit status needs to
be non 0. Now all sysroot tests commands expected to fail are verified
to do so.

Signed-off-by: Paulo Neves <ptsneves@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---

diff --git a/meta/lib/oeqa/selftest/cases/sysroot.py b/meta/lib/oeqa/selftest/cases/sysroot.py
index 588fc8c713a..294ba4a4a06 100644
--- a/meta/lib/oeqa/selftest/cases/sysroot.py
+++ b/meta/lib/oeqa/selftest/cases/sysroot.py
@@ -45,6 +45,7 @@ TESTSTRING:pn-sysroot-test-arch2 = "%s"
         expected = "maximum shebang size exceeded, the maximum size is 128. [shebang-size]"
         res = bitbake("sysroot-shebang-test-native -c populate_sysroot", ignore_status=True)
         self.assertTrue(expected in res.output, msg=res.output)
+        self.assertTrue(res.status != 0)
 
     def test_sysroot_la(self):
         """
@@ -57,10 +58,12 @@ TESTSTRING:pn-sysroot-test-arch2 = "%s"
         res = bitbake("sysroot-la-test -c populate_sysroot", ignore_status=True)
         self.assertTrue(expected in res.output, msg=res.output)
         self.assertTrue('[la]' in res.output, msg=res.output)
+        self.assertTrue(res.status != 0)
 
         res = bitbake("sysroot-la-test-native -c populate_sysroot", ignore_status=True)
         self.assertTrue(expected in res.output, msg=res.output)
         self.assertTrue('[la]' in res.output, msg=res.output)
+        self.assertTrue(res.status != 0)
 
     def test_sysroot_pkgconfig(self):
         """
@@ -73,7 +76,9 @@ TESTSTRING:pn-sysroot-test-arch2 = "%s"
         res = bitbake("sysroot-pc-test -c populate_sysroot", ignore_status=True)
         self.assertTrue('[pkgconfig]' in res.output, msg=res.output)
         self.assertTrue(expected in res.output, msg=res.output)
+        self.assertTrue(res.status != 0)
 
         res = bitbake("sysroot-pc-test-native -c populate_sysroot", ignore_status=True)
         self.assertTrue(expected in res.output, msg=res.output)
         self.assertTrue('[pkgconfig]' in res.output, msg=res.output)
+        self.assertTrue(res.status != 0)