From: João Carmona <jpsc@users.noreply.github.com>
Date: Tue, 13 Feb 2024 03:54:59 +0000 (+0100)
Subject: perf(runtime): improve `getType()` GC and speed (#10327)
X-Git-Tag: v3.4.19~11
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=603a1e1f5ad587c077f0d974c1bbe856be22ebe9;p=thirdparty%2Fvuejs%2Fcore.git

perf(runtime): improve `getType()` GC and speed (#10327)
---

diff --git a/packages/runtime-core/src/componentProps.ts b/packages/runtime-core/src/componentProps.ts
index d1822a1638..2d91affe08 100644
--- a/packages/runtime-core/src/componentProps.ts
+++ b/packages/runtime-core/src/componentProps.ts
@@ -597,8 +597,23 @@ function validatePropName(key: string) {
 // use function string name to check type constructors
 // so that it works across vms / iframes.
 function getType(ctor: Prop<any>): string {
-  const match = ctor && ctor.toString().match(/^\s*(function|class) (\w+)/)
-  return match ? match[2] : ctor === null ? 'null' : ''
+  // Early return for null to avoid unnecessary computations
+  if (ctor === null) {
+    return 'null'
+  }
+
+  // Avoid using regex for common cases by checking the type directly
+  if (typeof ctor === 'function') {
+    // Using name property to avoid converting function to string
+    return ctor.name || ''
+  } else if (typeof ctor === 'object') {
+    // Attempting to directly access constructor name if possible
+    const name = ctor.constructor && ctor.constructor.name
+    return name || ''
+  }
+
+  // Fallback for other types (though they're less likely to have meaningful names here)
+  return ''
 }
 
 function isSameType(a: Prop<any>, b: Prop<any>): boolean {