From: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Date: Fri, 19 Aug 2022 04:49:24 +0000 (+1200)
Subject: py/getopt: improve messages for bad --debug arg
X-Git-Tag: talloc-2.4.0~1183
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=604832b8ffd242025d613fb5e35707a5185e8855;p=thirdparty%2Fsamba.git

py/getopt: improve messages for bad --debug arg

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/python/samba/getopt.py b/python/samba/getopt.py
index 4e70998d9d9..76bee5e9b7f 100644
--- a/python/samba/getopt.py
+++ b/python/samba/getopt.py
@@ -67,7 +67,10 @@ class SambaOptions(optparse.OptionGroup):
         self._configfile = arg
 
     def _set_debuglevel(self, option, opt_str, arg, parser):
-        self._lp.set('debug level', arg)
+        try:
+            self._lp.set('debug level', arg)
+        except RuntimeError:
+            raise OptionError(f"invalid -d/--debug value: '{arg}'")
         parser.values.debuglevel = arg
 
     def _set_realm(self, option, opt_str, arg, parser):