From: Nick Kew Date: Tue, 15 Sep 2009 16:10:21 +0000 (+0000) Subject: Change "DefaultHandler" to "Fallback" as discussed on list and X-Git-Tag: 2.3.3~295 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=608b02264eb7faf4efaf58371199748d25f86ee5;p=thirdparty%2Fapache%2Fhttpd.git Change "DefaultHandler" to "Fallback" as discussed on list and today on IRC, in the hope that everyone will be satisfied. PR: 47184 + subsequent veto of original directive name git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@815380 13f79535-47bb-0310-9956-ffa450edef68 --- diff --git a/CHANGES b/CHANGES index 93b8494e11a..0d6494c9007 100644 --- a/CHANGES +++ b/CHANGES @@ -105,7 +105,7 @@ Changes with Apache 2.3.3 *) mod_alias: ensure Redirect issues a valid URL. PR 44020 [HÃ¥kon Stordahl ] - *) mod_dir: add DefaultHandler directive, to enable admin to specify + *) mod_dir: add Fallback directive, to enable admin to specify an action to happen when a URL maps to no file, without resorting to ErrorDocument or mod_rewrite. PR 47184 [Nick Kew] diff --git a/docs/manual/mod/mod_dir.xml b/docs/manual/mod/mod_dir.xml index 5ed2888ff3a..8f52dc98490 100644 --- a/docs/manual/mod/mod_dir.xml +++ b/docs/manual/mod/mod_dir.xml @@ -157,9 +157,9 @@ a directory -DefaultMapping +Fallback Define a default URL for requests that don't map to a file -DefaultMapping local-url +Fallback local-url None - httpd will return 404 (Not Found) server configvirtual host directory.htaccess @@ -169,10 +169,10 @@ a directory in your filesystem, and would otherwise return HTTP 404 (Not Found). For example

- DefaultMapping default.php + Fallback not-404.php

will cause requests for non-existent files to be handled by - default.php, while requests for files that exist + not-404.php, while requests for files that exist are unaffected.

diff --git a/modules/mappers/mod_dir.c b/modules/mappers/mod_dir.c index 527842e078a..d9efd539db6 100644 --- a/modules/mappers/mod_dir.c +++ b/modules/mappers/mod_dir.c @@ -83,7 +83,7 @@ static const char *configure_slash(cmd_parms *cmd, void *d_, int arg) static const command_rec dir_cmds[] = { - AP_INIT_TAKE1("DefaultMapping", ap_set_string_slot, + AP_INIT_TAKE1("Fallback", ap_set_string_slot, (void*)APR_OFFSETOF(dir_config_rec, dflt), DIR_CMD_PERMS, "Set a default handler"), AP_INIT_RAW_ARGS("DirectoryIndex", add_index, NULL, DIR_CMD_PERMS, @@ -128,7 +128,7 @@ static int fixup_dflt(request_rec *r) if (name_ptr == NULL) { return DECLINED; } - /* XXX: if DefaultHandler points to something that doesn't exist, + /* XXX: if Fallback points to something that doesn't exist, * this may recurse until it hits the limit for internal redirects * before returning an Internal Server Error. */