From: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Date: Mon, 29 Aug 2022 01:11:02 +0000 (-0700)
Subject: gh-95950: Add a test for both `csv.Dialect` and `kwargs` (GH-95951)
X-Git-Tag: v3.10.7~25
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=60f704f1258d8c225ad0a9ba3f342b553064206a;p=thirdparty%2FPython%2Fcpython.git

gh-95950: Add a test for both `csv.Dialect` and `kwargs` (GH-95951)

(cherry picked from commit 1c01bd28a0ec7e46e570a07d970c590b1809f8f1)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
---

diff --git a/Lib/test/test_csv.py b/Lib/test/test_csv.py
index 6e5dfc63d43c..d94a6f24597b 100644
--- a/Lib/test/test_csv.py
+++ b/Lib/test/test_csv.py
@@ -421,6 +421,34 @@ class TestDialectRegistry(unittest.TestCase):
         self.assertEqual(csv.get_dialect(name).delimiter, ';')
         self.assertEqual([['X', 'Y', 'Z']], list(csv.reader(['X;Y;Z'], name)))
 
+    def test_register_kwargs_override(self):
+        class mydialect(csv.Dialect):
+            delimiter = "\t"
+            quotechar = '"'
+            doublequote = True
+            skipinitialspace = False
+            lineterminator = '\r\n'
+            quoting = csv.QUOTE_MINIMAL
+
+        name = 'test_dialect'
+        csv.register_dialect(name, mydialect,
+                             delimiter=';',
+                             quotechar="'",
+                             doublequote=False,
+                             skipinitialspace=True,
+                             lineterminator='\n',
+                             quoting=csv.QUOTE_ALL)
+        self.addCleanup(csv.unregister_dialect, name)
+
+        # Ensure that kwargs do override attributes of a dialect class:
+        dialect = csv.get_dialect(name)
+        self.assertEqual(dialect.delimiter, ';')
+        self.assertEqual(dialect.quotechar, "'")
+        self.assertEqual(dialect.doublequote, False)
+        self.assertEqual(dialect.skipinitialspace, True)
+        self.assertEqual(dialect.lineterminator, '\n')
+        self.assertEqual(dialect.quoting, csv.QUOTE_ALL)
+
     def test_incomplete_dialect(self):
         class myexceltsv(csv.Dialect):
             delimiter = "\t"