From: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Date: Sun, 7 Sep 2025 09:52:35 +0000 (+0200)
Subject: [3.13] gh-138584: Increase test coverage for `collections.UserList` (GH-138590) ... 
X-Git-Tag: v3.13.8~97
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=614c493406c3b6f805096d4e13fcc1a7fc506fef;p=thirdparty%2FPython%2Fcpython.git

[3.13] gh-138584: Increase test coverage for `collections.UserList` (GH-138590) (#138611)

gh-138584: Increase test coverage for `collections.UserList` (GH-138590)

Some common tests in `test.list_tests.CommonTest` explicitly tested `list`
instead of testing the underlying list-like type defined in `type2test`.

---------
(cherry picked from commit d7b9ea5cab984497526fcc0b988e4eb5988c1e88)

Co-authored-by: dbXD320 <devanshbaghla320@gmail.com>
Co-authored-by: Devansh Baghla <devanshbaghla34@gmail.com>
---

diff --git a/Lib/test/list_tests.py b/Lib/test/list_tests.py
index dbc5ef4f9f2c..65dfa41b26e9 100644
--- a/Lib/test/list_tests.py
+++ b/Lib/test/list_tests.py
@@ -31,13 +31,13 @@ class CommonTest(seq_tests.CommonTest):
         self.assertEqual(a, b)
 
     def test_getitem_error(self):
-        a = []
+        a = self.type2test([])
         msg = "list indices must be integers or slices"
         with self.assertRaisesRegex(TypeError, msg):
             a['a']
 
     def test_setitem_error(self):
-        a = []
+        a = self.type2test([])
         msg = "list indices must be integers or slices"
         with self.assertRaisesRegex(TypeError, msg):
             a['a'] = "python"
@@ -558,7 +558,7 @@ class CommonTest(seq_tests.CommonTest):
         class F(object):
             def __iter__(self):
                 raise KeyboardInterrupt
-        self.assertRaises(KeyboardInterrupt, list, F())
+        self.assertRaises(KeyboardInterrupt, self.type2test, F())
 
     def test_exhausted_iterator(self):
         a = self.type2test([1, 2, 3])