From: Ralph Boehme <slow@samba.org>
Date: Wed, 16 Sep 2020 13:40:36 +0000 (+0200)
Subject: s4/torture: use unique filename for torture_samba3_hide() test
X-Git-Tag: talloc-2.3.2~335
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=616b64c3627bfee4f4f8541c0b5e6a675c24a643;p=thirdparty%2Fsamba.git

s4/torture: use unique filename for torture_samba3_hide() test

The filename "test.txt" is also used by other tests and without O_PATH the file
can't be removed at the end of this tests: open_smb_fname_fsp() fails with
ACCESS_DENIED because the POSIX mode of the file is 0000 and become_root() used
in the #ifndef O_PATH fallback case doesn't work in CI.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
---

diff --git a/source4/torture/raw/samba3hide.c b/source4/torture/raw/samba3hide.c
index f980ffceb6d..d28f91e8a86 100644
--- a/source4/torture/raw/samba3hide.c
+++ b/source4/torture/raw/samba3hide.c
@@ -156,7 +156,7 @@ static NTSTATUS smbcli_chmod(struct smbcli_tree *tree, const char *fname,
 
 bool torture_samba3_hide(struct torture_context *torture, struct smbcli_state *cli)
 {
-	const char *fname = "test.txt";
+	const char *fname = "torture_samba3_hide.txt";
 	int fnum;
 	NTSTATUS status;
 	struct smbcli_tree *hideunread;