From: Michael Adam <obnox@samba.org>
Date: Wed, 23 Jul 2008 22:30:07 +0000 (+0200)
Subject: dssync keytab: use add_to_keytab_entries() for pwd history in parse_object().
X-Git-Tag: samba-3.3.0pre1~338
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=61f071de92a7011c70f72dc31fef4430ffb1515a;p=thirdparty%2Fsamba.git

dssync keytab: use add_to_keytab_entries() for pwd history in parse_object().

Michael
---

diff --git a/source/libnet/libnet_dssync_keytab.c b/source/libnet/libnet_dssync_keytab.c
index eb3a936bcd0..b1f0a35d8b9 100644
--- a/source/libnet/libnet_dssync_keytab.c
+++ b/source/libnet/libnet_dssync_keytab.c
@@ -100,7 +100,6 @@ static NTSTATUS parse_object(TALLOC_CTX *mem_ctx,
 {
 	NTSTATUS status = NT_STATUS_OK;
 	uchar nt_passwd[16];
-	struct libnet_keytab_entry entry;
 	DATA_BLOB *blob;
 	int i = 0;
 	struct drsuapi_DsReplicaAttribute *attr;
@@ -215,18 +214,11 @@ static NTSTATUS parse_object(TALLOC_CTX *mem_ctx,
 	}
 
 	for (; i<pwd_history_len; i++) {
-
-		entry.kvno = kvno--;
-		entry.name = talloc_strdup(mem_ctx, name);
-		entry.principal = talloc_asprintf(mem_ctx, "%s@%s",
-						  name, ctx->dns_domain_name);
-		entry.password = data_blob_talloc(mem_ctx, &pwd_history[i*16], 16);
-		NT_STATUS_HAVE_NO_MEMORY(entry.name);
-		NT_STATUS_HAVE_NO_MEMORY(entry.principal);
-		NT_STATUS_HAVE_NO_MEMORY(entry.password.data);
-
-		ADD_TO_ARRAY(mem_ctx, struct libnet_keytab_entry, entry,
-			     &ctx->entries, &ctx->count);
+		status = add_to_keytab_entries(mem_ctx, ctx, kvno--, name, NULL,
+				data_blob_talloc(mem_ctx, &pwd_history[i*16], 16));
+		if (!NT_STATUS_IS_OK(status)) {
+			break;
+		}
 	}
 
 	return status;