From: Volker Lendecke <vl@samba.org>
Date: Sun, 23 Jan 2011 08:12:43 +0000 (+0100)
Subject: s3: Fix an infinite loop
X-Git-Tag: tevent-0.9.11~1274
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=61f7d7cdeccb1f733590e8bdb8229b32363a815e;p=thirdparty%2Fsamba.git

s3: Fix an infinite loop

If select returns EBADF (which should NEVER happen), then we loop infinitely
because the select masks seem all active.

I've been given an strace where smbd floods syslog with inotify-related
error messages. The strace shows that select returns EBADF, and we're calling
the inotify event callback. It then complains there's no data on the inotify
fd.

Metze, please check!

We might need to fix this in 3.4 and 3.5 as well. And we need to find the
deeper reason where we close a file descriptor and don't tell the events
system about it.

Volker

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sun Jan 23 10:05:39 CET 2011 on sn-devel-104
---

diff --git a/source3/lib/events.c b/source3/lib/events.c
index d987072884d..802a2e57313 100644
--- a/source3/lib/events.c
+++ b/source3/lib/events.c
@@ -120,6 +120,10 @@ bool run_events(struct tevent_context *ev,
 		return false;
 	}
 
+	if (selrtn <= 0) {
+		return false;
+	}
+
 	for (fde = ev->fd_events; fde; fde = fde->next) {
 		uint16 flags = 0;