From: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com> Date: Sat, 13 Jul 2024 14:28:49 +0000 (+0200) Subject: [3.13] gh-121497: Make Pyrepl respect correctly the history with input hook set ... X-Git-Tag: v3.13.0b4~69 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=62572f10aa3044e3a5b0a1a3af9a3c3286a61ddf;p=thirdparty%2FPython%2Fcpython.git [3.13] gh-121497: Make Pyrepl respect correctly the history with input hook set (GH-121498) (#121703) gh-121497: Make Pyrepl respect correctly the history with input hook set (GH-121498) (cherry picked from commit 4e36dd7d87eb0f1bd1ecd53e368c16a5f75967a0) Co-authored-by: Pablo Galindo Salgado --- diff --git a/Lib/_pyrepl/unix_console.py b/Lib/_pyrepl/unix_console.py index c4dedd97d1e1..18b2bba91c8c 100644 --- a/Lib/_pyrepl/unix_console.py +++ b/Lib/_pyrepl/unix_console.py @@ -383,6 +383,8 @@ class UnixConsole(Console): Returns: - Event: Event object from the event queue. """ + if not block and not self.wait(timeout=0): + return None while self.event_queue.empty(): while True: try: @@ -397,8 +399,6 @@ class UnixConsole(Console): raise else: break - if not block: - break return self.event_queue.get() def wait(self, timeout: float | None = None) -> bool: diff --git a/Misc/NEWS.d/next/Core and Builtins/2024-07-08-17-15-14.gh-issue-121497.I8hMDC.rst b/Misc/NEWS.d/next/Core and Builtins/2024-07-08-17-15-14.gh-issue-121497.I8hMDC.rst new file mode 100644 index 000000000000..33de31abebe7 --- /dev/null +++ b/Misc/NEWS.d/next/Core and Builtins/2024-07-08-17-15-14.gh-issue-121497.I8hMDC.rst @@ -0,0 +1,2 @@ +Fix a bug that was preventing the REPL to correctly respect the history when +an input hook was set. Patch by Pablo Galindo