From: Joseph Sutton <josephsutton@catalyst.net.nz>
Date: Mon, 1 May 2023 01:04:58 +0000 (+1200)
Subject: s4:kdc: Don’t call memcpy() with a NULL pointer
X-Git-Tag: talloc-2.4.1~732
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=6258173a62e3fbb9cd103b72175874e8346571ea;p=thirdparty%2Fsamba.git

s4:kdc: Don’t call memcpy() with a NULL pointer

Doing so is undefined behaviour.

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Fri May  5 03:52:30 UTC 2023 on atb-devel-224
---

diff --git a/source4/kdc/kpasswd-service.c b/source4/kdc/kpasswd-service.c
index 43dd8e0d866..f8ca1e79498 100644
--- a/source4/kdc/kpasswd-service.c
+++ b/source4/kdc/kpasswd-service.c
@@ -379,9 +379,11 @@ reply:
 	RSSVAL(reply->data, 0, reply->length);
 	RSSVAL(reply->data, 2, 1);
 	RSSVAL(reply->data, 4, ap_rep_blob.length);
-	memcpy(reply->data + HEADER_LEN,
-	       ap_rep_blob.data,
-	       ap_rep_blob.length);
+	if (ap_rep_blob.data != NULL) {
+		memcpy(reply->data + HEADER_LEN,
+		       ap_rep_blob.data,
+		       ap_rep_blob.length);
+	}
 	memcpy(reply->data + HEADER_LEN + ap_rep_blob.length,
 	       enc_data_blob.data,
 	       enc_data_blob.length);