From: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com> Date: Sun, 15 Mar 2020 19:55:41 +0000 (-0700) Subject: Fix a possible refleak in tupleobject.c (GH-19018) X-Git-Tag: v3.7.8rc1~138 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=627e7bc1bb203b6472af567f2effee952c34b34c;p=thirdparty%2FPython%2Fcpython.git Fix a possible refleak in tupleobject.c (GH-19018) (cherry picked from commit c81609e44eed641d3b8a137daa31ef35501c1f85) Co-authored-by: Hai Shi --- diff --git a/Objects/tupleobject.c b/Objects/tupleobject.c index 7ee06e20e4a9..2a1b8fad98db 100644 --- a/Objects/tupleobject.c +++ b/Objects/tupleobject.c @@ -696,8 +696,10 @@ tuple_subtype_new(PyTypeObject *type, PyObject *iterable) return NULL; assert(PyTuple_Check(tmp)); newobj = type->tp_alloc(type, n = PyTuple_GET_SIZE(tmp)); - if (newobj == NULL) + if (newobj == NULL) { + Py_DECREF(tmp); return NULL; + } for (i = 0; i < n; i++) { item = PyTuple_GET_ITEM(tmp, i); Py_INCREF(item);