From: Thomas Markwalder <tmark@isc.org>
Date: Thu, 9 Feb 2023 20:09:04 +0000 (-0500)
Subject: [#2538] Addressed more comments
X-Git-Tag: Kea-2.3.5~46
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=62941c7e58eec4c88079a763119bd9000e2abd4e;p=thirdparty%2Fkea.git

[#2538] Addressed more comments

src/lib/dhcp/option.cc
    Removed dead line

src/lib/dhcpsrv/tests/host_reservation_parser_unittest.cc
    Removed unneeded include
---

diff --git a/src/lib/dhcp/option.cc b/src/lib/dhcp/option.cc
index b50df37601..5b95dac699 100644
--- a/src/lib/dhcp/option.cc
+++ b/src/lib/dhcp/option.cc
@@ -333,7 +333,6 @@ void Option::addOption(OptionPtr opt) {
         // Do not allow options to be added to themselves as this
         // can lead to infinite recursion.
         isc_throw(InvalidOperation, "option cannot be added to itself: " << toText());
-        // return;
     }
 
     options_.insert(make_pair(opt->getType(), opt));
diff --git a/src/lib/dhcpsrv/tests/host_reservation_parser_unittest.cc b/src/lib/dhcpsrv/tests/host_reservation_parser_unittest.cc
index b79a032bcc..a7c1de49e0 100644
--- a/src/lib/dhcpsrv/tests/host_reservation_parser_unittest.cc
+++ b/src/lib/dhcpsrv/tests/host_reservation_parser_unittest.cc
@@ -10,7 +10,6 @@
 #include <cc/data.h>
 #include <dhcp/duid.h>
 #include <dhcp/hwaddr.h>
-#include <dhcp/option_custom.h>
 #include <dhcp/option_int.h>
 #include <dhcp/option4_addrlst.h>
 #include <dhcp/option6_addrlst.h>