From: Fabian Keil <fk@fabiankeil.de>
Date: Tue, 25 Aug 2009 16:15:35 +0000 (+0200)
Subject: Mark what looks like a bug in in _gnutls_srp_pwd_read_entry()
X-Git-Tag: gnutls_2_9_4~33
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=62edfa4eb29d6ed91d236312a5efa83c70c9c8cd;p=thirdparty%2Fgnutls.git

Mark what looks like a bug in in _gnutls_srp_pwd_read_entry()

Signed-off-by: Simon Josefsson <simon@josefsson.org>
---

diff --git a/lib/auth_srp_passwd.c b/lib/auth_srp_passwd.c
index 4475abb3e9..376effda97 100644
--- a/lib/auth_srp_passwd.c
+++ b/lib/auth_srp_passwd.c
@@ -347,7 +347,8 @@ _gnutls_srp_pwd_read_entry (gnutls_session_t state, char *username,
 	      /* Keep the last index in memory, so we can retrieve fake parameters (g,n)
 	       * when the user does not exist.
 	       */
-	      last_idx = idx;
+              /* XXX: last_idx will not be read as both if block branches return. */
+              last_idx = idx;
 	      if (pwd_read_conf (cred->password_conf_file, entry, idx) == 0)
 		{
 		  return 0;