From: Mark Spencer <markster@digium.com>
Date: Sun, 9 May 2004 20:46:18 +0000 (+0000)
Subject: Fix accidental strlen_zero mistransfer (bug #1592)
X-Git-Tag: 1.0.0-rc1~510
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=62eef7c6953b01a45f9dbd737c9e33b50dc251c7;p=thirdparty%2Fasterisk.git

Fix accidental strlen_zero mistransfer (bug #1592)


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@2936 65c4cc65-6c06-0410-ace0-fbb531ad65f3
---

diff --git a/channels/chan_sip.c b/channels/chan_sip.c
index 5646db5d5d..4841da7f5d 100755
--- a/channels/chan_sip.c
+++ b/channels/chan_sip.c
@@ -5020,11 +5020,11 @@ static void receive_info(struct sip_pvt *p, struct sip_request *req)
 
 		/* Try getting the "signal=" part */
 		if (ast_strlen_zero(c = get_sdp(req, "Signal")) && ast_strlen_zero(c = get_sdp(req, "d"))) {
-		   strncpy(buf, c, sizeof(buf) - 1);
-		} else {
 		   ast_log(LOG_WARNING, "Unable to retrieve DTMF signal from INFO message from %s\n", p->callid);
 		   transmit_response(p, "200 OK", req); /* Should return error */
 		   return;
+		} else {
+		   strncpy(buf, c, sizeof(buf) - 1);
 		}
 	
 		if (p->owner) {	/* PBX call */