From: Martin Schwenke <martin@meltin.net>
Date: Wed, 1 Jun 2016 05:56:42 +0000 (+1000)
Subject: ctdb-recoverd: Fix buggy function return on memory allocation failure
X-Git-Tag: tdb-1.3.10~928
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=630f169653b731025aeb0babcd8cf0710bc5d316;p=thirdparty%2Fsamba.git

ctdb-recoverd: Fix buggy function return on memory allocation failure

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
---

diff --git a/ctdb/server/ctdb_recoverd.c b/ctdb/server/ctdb_recoverd.c
index adff56cdce5..538d4301adb 100644
--- a/ctdb/server/ctdb_recoverd.c
+++ b/ctdb/server/ctdb_recoverd.c
@@ -1592,7 +1592,7 @@ static bool ctdb_recovery_lock(struct ctdb_context *ctdb)
 
 	h = ctdb_cluster_mutex(ctdb, ctdb->recovery_lock, 0);
 	if (h == NULL) {
-		return -1;
+		return false;
 	}
 
 	ctdb_cluster_mutex_set_handler(h, hold_reclock_handler, &s);