From: Emil Velikov <emil.l.velikov@gmail.com>
Date: Wed, 18 Sep 2024 15:49:08 +0000 (+0100)
Subject: tools/rmmod: return EXIT_FAILURE if kmod_module_new_* fails
X-Git-Tag: v34~313
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=6317b4af37816e9551140cd83d20c0b6194875fc;p=thirdparty%2Fkmod.git

tools/rmmod: return EXIT_FAILURE if kmod_module_new_* fails

In the unlikely case where kmod_module_new_from_{path,name} fails,
rmmod will return success. Change that to EXIT_FAILURE.

Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
Link: https://github.com/kmod-project/kmod/pull/138
Signed-off-by: Lucas De Marchi <lucas.de.marchi@gmail.com>
---

diff --git a/tools/rmmod.c b/tools/rmmod.c
index 2d82c860..5246bad3 100644
--- a/tools/rmmod.c
+++ b/tools/rmmod.c
@@ -156,6 +156,7 @@ static int do_rmmod(int argc, char *argv[])
 		if (err < 0) {
 			ERR("could not use module %s: %s\n", arg,
 			    strerror(-err));
+			r = EXIT_FAILURE;
 			break;
 		}