From: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Date: Thu, 9 Nov 2023 15:37:04 +0000 (+0100)
Subject: [3.11] gh-111881: Import doctest lazily in libregrtest (GH-111884) (#111894)
X-Git-Tag: v3.11.7~86
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=63205e5692041c59283b8fa667310d12fd5846ee;p=thirdparty%2FPython%2Fcpython.git

[3.11] gh-111881: Import doctest lazily in libregrtest (GH-111884) (#111894)

gh-111881: Import doctest lazily in libregrtest (GH-111884)

In most cases, doctest is not needed. So don't always import it at
startup. The change reduces the number of modules already
imported when a test is run.
(cherry picked from commit 6f09f69b7f85962f66d10637c3325bbb2b2d9853)

Co-authored-by: Victor Stinner <vstinner@python.org>
---

diff --git a/Lib/test/libregrtest/single.py b/Lib/test/libregrtest/single.py
index ad75ef54a8c3..5c7bc7d40fb3 100644
--- a/Lib/test/libregrtest/single.py
+++ b/Lib/test/libregrtest/single.py
@@ -1,4 +1,3 @@
-import doctest
 import faulthandler
 import gc
 import importlib
@@ -99,14 +98,18 @@ def regrtest_runner(result: TestResult, test_func, runtests: RunTests) -> None:
             stats = test_result
         case unittest.TestResult():
             stats = TestStats.from_unittest(test_result)
-        case doctest.TestResults():
-            stats = TestStats.from_doctest(test_result)
         case None:
             print_warning(f"{result.test_name} test runner returned None: {test_func}")
             stats = None
         case _:
-            print_warning(f"Unknown test result type: {type(test_result)}")
-            stats = None
+            # Don't import doctest at top level since only few tests return
+            # a doctest.TestResult instance.
+            import doctest
+            if isinstance(test_result, doctest.TestResults):
+                stats = TestStats.from_doctest(test_result)
+            else:
+                print_warning(f"Unknown test result type: {type(test_result)}")
+                stats = None
 
     result.stats = stats