From: Richard Sharpe <realrichardsharpe@gmail.com>
Date: Thu, 17 May 2012 03:21:34 +0000 (-0700)
Subject: Check the return from create_acl_blob
X-Git-Tag: samba-4.0.0alpha21~111
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=632af6645376185500820a5be9dbf5c0c3d1e515;p=thirdparty%2Fsamba.git

Check the return from create_acl_blob

Autobuild-User: Richard Sharpe <sharpe@samba.org>
Autobuild-Date: Thu May 17 07:17:29 CEST 2012 on sn-devel-104
---

diff --git a/source3/modules/vfs_acl_common.c b/source3/modules/vfs_acl_common.c
index 221b43f7481..c7bce5710aa 100644
--- a/source3/modules/vfs_acl_common.c
+++ b/source3/modules/vfs_acl_common.c
@@ -592,10 +592,12 @@ static NTSTATUS fset_nt_acl_common(vfs_handle_struct *handle, files_struct *fsp,
 		NDR_PRINT_DEBUG(security_descriptor,
 			discard_const_p(struct security_descriptor, psd));
 	}
-	/*
-	 * Perhaps create_acl_blob should have a status return as well
-	 */
-	create_acl_blob(psd, &blob, XATTR_SD_HASH_TYPE_SHA256, hash);
+	status = create_acl_blob(psd, &blob, XATTR_SD_HASH_TYPE_SHA256, hash);
+	if (!NT_STATUS_IS_OK(status)) {
+		DEBUG(10, ("fset_nt_acl_xattr: create_acl_blob failed\n"));
+		return status;
+	}
+
 	status = store_acl_blob_fsp(handle, fsp, &blob);
 
 	return status;