From: Raymond Hettinger <python@rcn.com>
Date: Sat, 4 Jan 2003 09:30:32 +0000 (+0000)
Subject: Correct long standing bugs in the methods for random distributions.
X-Git-Tag: v2.2.3c1~191
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=63b5156e6e4a01737c333265772c677035fce657;p=thirdparty%2FPython%2Fcpython.git

Correct long standing bugs in the methods for random distributions.
The range of u=random() is [0,1), so log(u) and 1/x can fail.
Fix by setting u=1-random() or by reselecting for a usable value.
---

diff --git a/Lib/random.py b/Lib/random.py
index 948b6935cfe7..85aa7236446f 100644
--- a/Lib/random.py
+++ b/Lib/random.py
@@ -399,7 +399,7 @@ class Random:
         random = self.random
         while 1:
             u1 = random()
-            u2 = random()
+            u2 = 1.0 - random()
             z = NV_MAGICCONST*(u1-0.5)/u2
             zz = z*z/4.0
             if zz <= -_log(u2):
@@ -535,7 +535,9 @@ class Random:
 
             while 1:
                 u1 = random()
-                u2 = random()
+                if not 1e-7 < u1 < .9999999:
+                    continue
+                u2 = 1.0 - random()
                 v = _log(u1/(1.0-u1))/ainv
                 x = alpha*_exp(v)
                 z = u1*u1*u2
@@ -667,7 +669,7 @@ class Random:
         """Pareto distribution.  alpha is the shape parameter."""
         # Jain, pg. 495
 
-        u = self.random()
+        u = 1.0 - self.random()
         return 1.0 / pow(u, 1.0/alpha)
 
 ## -------------------- Weibull --------------------
@@ -680,7 +682,7 @@ class Random:
         """
         # Jain, pg. 499; bug fix courtesy Bill Arms
 
-        u = self.random()
+        u = 1.0 - self.random()
         return alpha * pow(-_log(u), 1.0/beta)
 
 ## -------------------- test program --------------------