From: Vsevolod Stakhov <vsevolod@rspamd.com>
Date: Sat, 21 May 2022 12:33:25 +0000 (+0100)
Subject: [Minor] Reputation: Another try to fix dkim reputation
X-Git-Tag: 3.3~229
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=63e180d7d377c48d9353b8ce385c3fcddf438ffe;p=thirdparty%2Frspamd.git

[Minor] Reputation: Another try to fix dkim reputation
---

diff --git a/src/plugins/lua/reputation.lua b/src/plugins/lua/reputation.lua
index dd1cfd9133..0c8fc1c36c 100644
--- a/src/plugins/lua/reputation.lua
+++ b/src/plugins/lua/reputation.lua
@@ -218,8 +218,13 @@ local function dkim_reputation_filter(task, rule)
           rep_accepted_abs, rep_rejected_abs)
       if rep_accepted_abs > 0 or rep_rejected_abs > 0 then
         if rep_accepted_abs > rep_rejected_abs then
-          add_symbol_score(task, rule, -(rep_accepted_abs - rep_rejected_abs))
+          -- For accepted reputation we add symbol with just this reputation, either positive or negative
+          local final_rep = rep_accepted
+          if rep_accepted > 1.0 then final_rep = 1.0 end
+          if rep_accepted < -1.0 then final_rep = -1.0 end
+          add_symbol_score(task, rule, final_rep)
         else
+          -- For rejected case we use absolute values as it must always be positive
           add_symbol_score(task, rule, (rep_rejected_abs - rep_accepted_abs))
         end