From: sobolevn <mail@sobolevn.me>
Date: Thu, 6 Feb 2025 12:54:40 +0000 (+0300)
Subject: gh-129643: Fix `PyList_Insert` in free-threading builds (#129680)
X-Git-Tag: v3.14.0a5~93
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=63f0406d5ad25a55e49c3903b29407c50a17cfd5;p=thirdparty%2FPython%2Fcpython.git

gh-129643: Fix `PyList_Insert` in free-threading builds (#129680)
---

diff --git a/Misc/NEWS.d/next/Core_and_Builtins/2025-02-05-11-29-52.gh-issue-129643.4mGzvg.rst b/Misc/NEWS.d/next/Core_and_Builtins/2025-02-05-11-29-52.gh-issue-129643.4mGzvg.rst
new file mode 100644
index 000000000000..420e1fb9781f
--- /dev/null
+++ b/Misc/NEWS.d/next/Core_and_Builtins/2025-02-05-11-29-52.gh-issue-129643.4mGzvg.rst
@@ -0,0 +1 @@
+Fix thread safety of :c:func:`PyList_Insert` in free-threading builds.
diff --git a/Objects/listobject.c b/Objects/listobject.c
index 86fa21495564..120e353b709e 100644
--- a/Objects/listobject.c
+++ b/Objects/listobject.c
@@ -466,8 +466,8 @@ ins1(PyListObject *self, Py_ssize_t where, PyObject *v)
         where = n;
     items = self->ob_item;
     for (i = n; --i >= where; )
-        items[i+1] = items[i];
-    items[where] = Py_NewRef(v);
+        FT_ATOMIC_STORE_PTR_RELAXED(items[i+1], items[i]);
+    FT_ATOMIC_STORE_PTR_RELEASE(items[where], Py_NewRef(v));
     return 0;
 }