From: Timo Sirainen <tss@iki.fi>
Date: Tue, 16 Mar 2010 18:33:18 +0000 (+0200)
Subject: mail_storage_service_next() didn't always set error string.
X-Git-Tag: 2.0.beta4~37
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=63fc74d46d781e87edb6388e51a5bf942c5f8eab;p=thirdparty%2Fdovecot%2Fcore.git

mail_storage_service_next() didn't always set error string.

--HG--
branch : HEAD
---

diff --git a/src/lib-storage/mail-storage-service.c b/src/lib-storage/mail-storage-service.c
index 2830daa1b3..58f9c75cd0 100644
--- a/src/lib-storage/mail-storage-service.c
+++ b/src/lib-storage/mail-storage-service.c
@@ -847,8 +847,9 @@ int mail_storage_service_next(struct mail_storage_service_ctx *ctx,
 				    user_set->mail_chroot);
 
 	if (*home != '/' && *home != '\0') {
-		i_error("user %s: Relative home directory paths not supported: "
-			"%s", user->input.username, home);
+		*error_r = t_strdup_printf("user %s: "
+			"Relative home directory paths not supported: %s",
+			user->input.username, home);
 		return -1;
 	}
 
@@ -859,7 +860,8 @@ int mail_storage_service_next(struct mail_storage_service_ctx *ctx,
 		if (service_drop_privileges(user_set, user->system_groups_user,
 					    home, chroot, disallow_root,
 					    temp_priv_drop, FALSE, &error) < 0) {
-			i_error("Couldn't drop privileges: %s", error);
+			*error_r = t_strdup_printf(
+				"Couldn't drop privileges: %s", error);
 			return -1;
 		}
 		if (!temp_priv_drop ||