From: Martin v. Löwis <martin@v.loewis.de>
Date: Thu, 14 Aug 2008 20:12:06 +0000 (+0000)
Subject: Fix memory leak: Always DECREF obj in PyBuffer_Release.
X-Git-Tag: v2.6b3~81
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=64034f994c4f176c7a6c9747d8caf86d8df243cd;p=thirdparty%2FPython%2Fcpython.git

Fix memory leak: Always DECREF obj in PyBuffer_Release.
---

diff --git a/Objects/abstract.c b/Objects/abstract.c
index aca60bdfcf5f..68e15491b603 100644
--- a/Objects/abstract.c
+++ b/Objects/abstract.c
@@ -708,11 +708,9 @@ void
 PyBuffer_Release(Py_buffer *view)
 {
 	PyObject *obj = view->obj;
-	if (!obj || !Py_TYPE(obj)->tp_as_buffer || !Py_TYPE(obj)->tp_as_buffer->bf_releasebuffer)
-		/* Unmanaged buffer */
-		return;
-	Py_TYPE(obj)->tp_as_buffer->bf_releasebuffer(obj, view);
-	Py_DECREF(obj);
+	if (obj && Py_TYPE(obj)->tp_as_buffer && Py_TYPE(obj)->tp_as_buffer->bf_releasebuffer)
+		Py_TYPE(obj)->tp_as_buffer->bf_releasebuffer(obj, view);
+	Py_XDECREF(obj);
 	view->obj = NULL;
 }