From: Mark Andrews Date: Fri, 29 Apr 2022 02:25:25 +0000 (+1000) Subject: Remove dead code, result cannot be ISC_R_SUSPEND X-Git-Tag: v9.19.1~29^2 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=648ee547522ee314793841b59dc5d7eb34684373;p=thirdparty%2Fbind9.git Remove dead code, result cannot be ISC_R_SUSPEND *** CID 351290: Control flow issues (DEADCODE) /lib/dns/client.c: 1027 in dns_client_resolve() 1021 if (!client->readydone) { 1022 WAIT(&client->ready, &client->readylock); 1023 } 1024 UNLOCK(&client->readylock); 1025 1026 LOCK(&resarg->lock); >>> CID 351290: Control flow issues (DEADCODE) >>> Execution cannot reach the expression "result == ISC_R_SUSPEND" inside this statement: "if (result == ISC_R_SUCCESS...". 1027 if (result == ISC_R_SUCCESS || result == ISC_R_SUSPEND) { 1028 result = resarg->result; 1029 } 1030 if (result != ISC_R_SUCCESS && resarg->vresult != ISC_R_SUCCESS) { 1031 /* 1032 * If this lookup failed due to some error in DNSSEC --- diff --git a/lib/dns/client.c b/lib/dns/client.c index 412d708ea44..22145a827c6 100644 --- a/lib/dns/client.c +++ b/lib/dns/client.c @@ -1024,7 +1024,7 @@ dns_client_resolve(dns_client_t *client, const dns_name_t *name, UNLOCK(&client->readylock); LOCK(&resarg->lock); - if (result == ISC_R_SUCCESS || result == ISC_R_SUSPEND) { + if (result == ISC_R_SUCCESS) { result = resarg->result; } if (result != ISC_R_SUCCESS && resarg->vresult != ISC_R_SUCCESS) {