From: Volker Lendecke <vl@samba.org>
Date: Fri, 30 Mar 2018 17:13:03 +0000 (-0500)
Subject: dsdb: Fix CID 1034744 Dereference after null check
X-Git-Tag: talloc-2.1.13~59
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=64b144dce315642dcf606be4eacefab7036bb6c7;p=thirdparty%2Fsamba.git

dsdb: Fix CID 1034744 Dereference after null check

This HIGHLY looks like a cut&paste error...

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
---

diff --git a/source4/dsdb/schema/schema_syntax.c b/source4/dsdb/schema/schema_syntax.c
index 6205373a3fc..b434b6b0a5f 100644
--- a/source4/dsdb/schema/schema_syntax.c
+++ b/source4/dsdb/schema/schema_syntax.c
@@ -662,7 +662,7 @@ static WERROR dsdb_syntax_NTTIME_UTC_validate_ldb(const struct dsdb_syntax_ctx *
 		}
 
 		if (attr->rangeUpper) {
-			if ((int32_t)t > (int32_t)*attr->rangeLower) {
+			if ((int32_t)t > (int32_t)*attr->rangeUpper) {
 				return WERR_DS_INVALID_ATTRIBUTE_SYNTAX;
 			}
 		}