From: JINMEI Tatuya <jinmei@isc.org>
Date: Thu, 23 May 2013 22:07:29 +0000 (-0700)
Subject: [2522] revised "copy" test for SSHFP: make sure to use assignment, not copy.
X-Git-Tag: bind10-1.2.0beta1-release~430^2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=64bc0886402d587b65343fe6faecf35ed59eb029;p=thirdparty%2Fkea.git

[2522] revised "copy" test for SSHFP: make sure to use assignment, not copy.
---

diff --git a/src/lib/dns/tests/rdata_sshfp_unittest.cc b/src/lib/dns/tests/rdata_sshfp_unittest.cc
index 7df24d5637..b85dfa5ebe 100644
--- a/src/lib/dns/tests/rdata_sshfp_unittest.cc
+++ b/src/lib/dns/tests/rdata_sshfp_unittest.cc
@@ -152,12 +152,14 @@ TEST_F(Rdata_SSHFP_Test, badText) {
     checkFromText_LexerError("2 -1 123456789abcdef67890123456789abcdef67890");
 }
 
-TEST_F(Rdata_SSHFP_Test, copy) {
-    const generic::SSHFP rdata_sshfp2(rdata_sshfp);
+TEST_F(Rdata_SSHFP_Test, copyAndAssign) {
+    // Copy construct
+    generic::SSHFP rdata_sshfp2(rdata_sshfp);
     EXPECT_EQ(0, rdata_sshfp.compare(rdata_sshfp2));
 
-    const generic::SSHFP rdata_sshfp3 = rdata_sshfp;
-    EXPECT_EQ(0, rdata_sshfp.compare(rdata_sshfp3));
+    // Assignment, mainly to confirm it doesn't cause disruption.
+    rdata_sshfp2 = rdata_sshfp;
+    EXPECT_EQ(0, rdata_sshfp.compare(rdata_sshfp2));
 }
 
 TEST_F(Rdata_SSHFP_Test, createFromWire) {