From: Yu Watanabe <watanabe.yu+github@gmail.com>
Date: Sat, 14 May 2022 06:09:11 +0000 (+0900)
Subject: resolve: fix memleak
X-Git-Tag: v251~43
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=6530ca0d2b0255eec8e5620555f50961d11759eb;p=thirdparty%2Fsystemd.git

resolve: fix memleak

Fixes a bug introduced by 71aee23dba7faeef68e7232f444626267a6c90d7.

Fixes CID#1488763.
---

diff --git a/src/resolve/resolved-dns-answer.c b/src/resolve/resolved-dns-answer.c
index 08520d94247..3d42b0d000b 100644
--- a/src/resolve/resolved-dns-answer.c
+++ b/src/resolve/resolved-dns-answer.c
@@ -69,7 +69,7 @@ static int dns_answer_reserve_internal(DnsAnswer *a, size_t n) {
 
 DnsAnswer *dns_answer_new(size_t n) {
         _cleanup_ordered_set_free_ OrderedSet *s = NULL;
-        DnsAnswer *a;
+        _cleanup_(dns_answer_unrefp) DnsAnswer *a = NULL;
 
         if (n > UINT16_MAX)
                 n = UINT16_MAX;
@@ -90,7 +90,7 @@ DnsAnswer *dns_answer_new(size_t n) {
         if (dns_answer_reserve_internal(a, n) < 0)
                 return NULL;
 
-        return a;
+        return TAKE_PTR(a);
 }
 
 static DnsAnswer *dns_answer_free(DnsAnswer *a) {