From: Aki Tuomi <aki.tuomi@open-xchange.com>
Date: Thu, 7 Apr 2022 10:11:56 +0000 (+0300)
Subject: lib: net - Do not accept arbitrary numbers as IPv4 addresses in net_addr2ip_inet4_fast()
X-Git-Tag: 2.4.0~4142
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=65668f276977bad340de4d035e7f64b92d4d5877;p=thirdparty%2Fdovecot%2Fcore.git

lib: net - Do not accept arbitrary numbers as IPv4 addresses in net_addr2ip_inet4_fast()

Dovecot isn't currently using numbers as IPv4 addresses anywhere, so it doesn't need fast path
handling. The numbers are still accepted as IPv4 addresses by the libc code in slow path.
---

diff --git a/src/lib/net.c b/src/lib/net.c
index 65b983c109..affeca3552 100644
--- a/src/lib/net.c
+++ b/src/lib/net.c
@@ -937,12 +937,6 @@ static bool net_addr2ip_inet4_fast(const char *addr, struct ip_addr *ip)
 
 	if (str_parse_uint(addr, &num, &addr) < 0)
 		return FALSE;
-	if (*addr == '\0' && num <= 0xffffffff) {
-		/* single-number IPv4 address */
-		ip->u.ip4.s_addr = htonl(num);
-		ip->family = AF_INET;
-		return TRUE;
-	}
 
 	/* try to parse as a.b.c.d */
 	i = 0;