From: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com> Date: Fri, 10 Jun 2022 23:32:27 +0000 (-0700) Subject: gh-92886: Fix tests that fail when running with optimizations (`-O`) in `test_zipimpo... X-Git-Tag: v3.10.6~177 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=65e2a940fa90e95bcfccd9f90d0d10e78cc3b3d7;p=thirdparty%2FPython%2Fcpython.git gh-92886: Fix tests that fail when running with optimizations (`-O`) in `test_zipimport.py` (GH-93236) (cherry picked from commit 484a2357c8385694a077cf2ce0517f327fb0b172) Co-authored-by: jackh-ncl <1750152+jackh-ncl@users.noreply.github.com> --- diff --git a/Lib/test/test_zipimport.py b/Lib/test/test_zipimport.py index b291d5301690..da66dadaf149 100644 --- a/Lib/test/test_zipimport.py +++ b/Lib/test/test_zipimport.py @@ -653,7 +653,10 @@ class UncompressedZipImportTestCase(ImportHooksBaseTestCase): sys.path.insert(0, TEMP_ZIP) mod = importlib.import_module(TESTMOD) self.assertEqual(mod.test(1), 1) - self.assertRaises(AssertionError, mod.test, False) + if __debug__: + self.assertRaises(AssertionError, mod.test, False) + else: + self.assertEqual(mod.test(0), 0) def testImport_WithStuff(self): # try importing from a zipfile which contains additional diff --git a/Misc/NEWS.d/next/Tests/2022-05-25-23-00-35.gh-issue-92886.Y-vrWj.rst b/Misc/NEWS.d/next/Tests/2022-05-25-23-00-35.gh-issue-92886.Y-vrWj.rst new file mode 100644 index 000000000000..93c1ffe33f28 --- /dev/null +++ b/Misc/NEWS.d/next/Tests/2022-05-25-23-00-35.gh-issue-92886.Y-vrWj.rst @@ -0,0 +1 @@ +Fixing tests that fail when running with optimizations (``-O``) in ``test_zipimport.py``