From: Lennart Poettering <lennart@poettering.net>
Date: Wed, 7 Oct 2015 18:08:49 +0000 (+0200)
Subject: util: always enforce O_NOCTTY and O_CLOEXEC in openpt_in_namespace()
X-Git-Tag: v228~234^2~2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=660021d371d5698a86e914765239045a669e65fb;p=thirdparty%2Fsystemd.git

util: always enforce O_NOCTTY and O_CLOEXEC in openpt_in_namespace()

The child process is shortliving, hence always set O_NOCTTY so that the
tty doesn't quickly become controlling TTY and then gives it up again.
Also set O_CLOEXEC, because it's cleaner, and doesn't affect the parent
anyway.
---

diff --git a/src/basic/util.c b/src/basic/util.c
index 2855993afe1..f845e2dabbb 100644
--- a/src/basic/util.c
+++ b/src/basic/util.c
@@ -6143,7 +6143,7 @@ int openpt_in_namespace(pid_t pid, int flags) {
                 if (r < 0)
                         _exit(EXIT_FAILURE);
 
-                master = posix_openpt(flags);
+                master = posix_openpt(flags|O_NOCTTY|O_CLOEXEC);
                 if (master < 0)
                         _exit(EXIT_FAILURE);