From: Nikita Shubin Date: Thu, 26 Feb 2026 16:39:10 +0000 (+0300) Subject: serial: ns16550: Fix return-type warning X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=660d8e4fe92e4ca3f2173e3d00a25f6ae5f6e97d;p=thirdparty%2Fu-boot.git serial: ns16550: Fix return-type warning Fix compiler warning: drivers/serial/ns16550.c: In function ‘serial_in_dynamic’: drivers/serial/ns16550.c:153:1: warning: control reaches end of non-void function [-Wreturn-type] 153 | } | ^ Observed with gcc 15.2.1: $ riscv64-unknown-linux-gnu-gcc --version riscv64-unknown-linux-gnu-gcc (Gentoo 15.2.1_p20260214 p5) 15.2.1 Fixes: 62cbde4c4e46 ("serial: ns16550: Support run-time configuration") Signed-off-by: Nikita Shubin Reviewed-by: Tom Rini --- diff --git a/drivers/serial/ns16550.c b/drivers/serial/ns16550.c index c885b46cf56..2f24f47badf 100644 --- a/drivers/serial/ns16550.c +++ b/drivers/serial/ns16550.c @@ -137,9 +137,9 @@ static int serial_in_dynamic(struct ns16550_plat *plat, u8 *addr) } } else if (plat->flags & NS16550_FLAG_BE) { return readb(addr + (1 << plat->reg_shift) - 1); - } else { - return readb(addr); } + + return readb(addr); } #else static inline void serial_out_dynamic(struct ns16550_plat *plat, u8 *addr,