From: Volker Lendecke <vl@samba.org>
Date: Thu, 16 May 2024 10:04:23 +0000 (+0200)
Subject: smbd: Remove an unnecessary else branch
X-Git-Tag: tdb-1.4.11~622
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=661532c46c04bb4f80865874749b1e75671885d8;p=thirdparty%2Fsamba.git

smbd: Remove an unnecessary else branch

We return in the if branch, review with "git show -w"

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/source3/smbd/smb2_read.c b/source3/smbd/smb2_read.c
index 877ca955cdd..db0aca7ac68 100644
--- a/source3/smbd/smb2_read.c
+++ b/source3/smbd/smb2_read.c
@@ -581,11 +581,10 @@ static struct tevent_req *smbd_smb2_read_send(TALLOC_CTX *mem_ctx,
 	if (NT_STATUS_IS_OK(status)) {
 		tevent_req_done(req);
 		return tevent_req_post(req, ev);
-	} else {
-		if (!NT_STATUS_EQUAL(status, NT_STATUS_RETRY)) {
-			tevent_req_nterror(req, status);
-			return tevent_req_post(req, ev);
-		}
+	}
+	if (!NT_STATUS_EQUAL(status, NT_STATUS_RETRY)) {
+		tevent_req_nterror(req, status);
+		return tevent_req_post(req, ev);
 	}
 
 	/* Ok, read into memory. Allocate the out buffer. */