From: Martin Vidner <mvidner@suse.cz>
Date: Mon, 9 Dec 2019 14:58:54 +0000 (+0100)
Subject: getValue returns true/false
X-Git-Tag: v0.8.7^2~14
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=662922275beb1969e3109e00ff344c116a71eb5a;p=thirdparty%2Fsnapper.git

getValue returns true/false

consistently with other functions
---

diff --git a/snapper/XmlFile.cc b/snapper/XmlFile.cc
index c1972ac1..bf3f6385 100644
--- a/snapper/XmlFile.cc
+++ b/snapper/XmlFile.cc
@@ -142,11 +142,10 @@ namespace snapper
     {
 	xmlChar* tmp = xmlNodeGetContent(node);
 	if (tmp == nullptr)
-	    value = "";
-	else {
-	    value = (const char *) tmp;
-	    xmlFree(tmp);
-	}
+	    return false;
+
+	value = (const char *) tmp;
+	xmlFree(tmp);
 	return true;
     }
 
@@ -190,6 +189,7 @@ namespace snapper
 	xmlChar* tmp = xmlGetNoNsProp(node, (const xmlChar *) name);
 	if (tmp == nullptr)
 	    return false;
+
 	value = (const char *) tmp;
 	xmlFree(tmp);
 	return true;