From: Pauli Date: Mon, 22 Mar 2021 02:46:12 +0000 (+1000) Subject: test: fix coverity 1451534: improper use of negative value X-Git-Tag: openssl-3.0.0-alpha14~158 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=66325793ccd670c1ad8104666932bdb43cec6e42;p=thirdparty%2Fopenssl.git test: fix coverity 1451534: improper use of negative value Reviewed-by: Tomas Mraz (Merged from https://github.com/openssl/openssl/pull/14638) --- diff --git a/test/servername_test.c b/test/servername_test.c index ddf0417bc64..b417f8bcacb 100644 --- a/test/servername_test.c +++ b/test/servername_test.c @@ -52,8 +52,8 @@ static int get_sni_from_client_hello(BIO *bio, char **sni) memset(&pkt4, 0, sizeof(pkt4)); memset(&pkt5, 0, sizeof(pkt5)); - len = BIO_get_mem_data(bio, (char **)&data); - if (!TEST_true(PACKET_buf_init(&pkt, data, len)) + if (!TEST_long_ge(len = BIO_get_mem_data(bio, (char **)&data), 0) + || !TEST_true(PACKET_buf_init(&pkt, data, len)) /* Skip the record header */ || !PACKET_forward(&pkt, SSL3_RT_HEADER_LENGTH) /* Skip the handshake message header */