From: Ross Burton <ross.burton@arm.com>
Date: Mon, 10 Oct 2022 11:42:19 +0000 (+0100)
Subject: scripts/oe-check-sstate: cleanup
X-Git-Tag: lucaceresoli/bug-15201-perf-libtraceevent-missing~2842
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=663aa284adf312eb5c8a471e5dbff2634e87897d;p=thirdparty%2Fopenembedded%2Fopenembedded-core-contrib.git

scripts/oe-check-sstate: cleanup

The scriptutils import isn't used, there's no need to run bitbake
in a shell environment, and invoke bitbake as a list instead of a
string.

Signed-off-by: Ross Burton <ross.burton@arm.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---

diff --git a/scripts/oe-check-sstate b/scripts/oe-check-sstate
index f4cc5869de4..7f9f835da4c 100755
--- a/scripts/oe-check-sstate
+++ b/scripts/oe-check-sstate
@@ -18,7 +18,6 @@ import re
 scripts_path = os.path.dirname(os.path.realpath(__file__))
 lib_path = scripts_path + '/lib'
 sys.path = sys.path + [lib_path]
-import scriptutils
 import scriptpath
 scriptpath.add_bitbake_lib_path()
 import argparse_oe
@@ -51,11 +50,8 @@ def check(args):
             env['TMPDIR:forcevariable'] = tmpdir
 
         try:
-            output = subprocess.check_output(
-                    'bitbake -n %s' % ' '.join(args.target),
-                    stderr=subprocess.STDOUT,
-                    env=env,
-                    shell=True)
+            cmd = ['bitbake', '--dry-run'] + args.target
+            output = subprocess.check_output(cmd, stderr=subprocess.STDOUT, env=env)
 
             task_re = re.compile('NOTE: Running setscene task [0-9]+ of [0-9]+ \(([^)]+)\)')
             tasks = []