From: Joseph Sutton <josephsutton@catalyst.net.nz>
Date: Mon, 3 May 2021 02:43:04 +0000 (+1200)
Subject: python: Fix erroneous increments of reference counts
X-Git-Tag: tevent-0.11.0~804
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=66695f0f94775c4db24fb625fe78ff44d964b5ad;p=thirdparty%2Fsamba.git

python: Fix erroneous increments of reference counts

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
---

diff --git a/source3/passdb/py_passdb.c b/source3/passdb/py_passdb.c
index eb9239700c1..8988959bfc7 100644
--- a/source3/passdb/py_passdb.c
+++ b/source3/passdb/py_passdb.c
@@ -2075,8 +2075,6 @@ static PyObject *py_pdb_enum_group_mapping(PyObject *self, PyObject *args)
 	size_t i, num_entries;
 	PyObject *py_gmap_list, *py_group_map;
 
-	Py_INCREF(Py_None);
-
 	if (!PyArg_ParseTuple(args, "|O!ii:enum_group_mapping", dom_sid_Type, &py_domain_sid,
 					&lsa_sidtype_value, &unix_only)) {
 		talloc_free(frame);
@@ -2814,8 +2812,6 @@ static PyObject *py_pdb_search_aliases(PyObject *self, PyObject *args)
 	PyObject *py_domain_sid = Py_None;
 	struct dom_sid *domain_sid = NULL;
 
-	Py_INCREF(Py_None);
-
 	if (!PyArg_ParseTuple(args, "|O!:search_aliases", dom_sid_Type, &py_domain_sid)) {
 		talloc_free(frame);
 		return NULL;