From: Lennart Poettering <lennart@poettering.net>
Date: Mon, 29 Aug 2022 09:10:38 +0000 (+0200)
Subject: condition: allow literal string compares in SMBIOS condition
X-Git-Tag: v252-rc1~273^2~3
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=666d314a743a59005b4ccef5df5811bd135a3d9d;p=thirdparty%2Fsystemd.git

condition: allow literal string compares in SMBIOS condition

This ensures that "=" and "!=" are now interpreted as literal string
compares, and "==" and "<>" are for version compares.

This is not a compat break, since the SMBIOS stuff has not been included
in any release yet.

Main reason to do this, is to be systematic with the other conditions
that check for text stuff.
---

diff --git a/src/shared/condition.c b/src/shared/condition.c
index f893937156f..6c8023143b8 100644
--- a/src/shared/condition.c
+++ b/src/shared/condition.c
@@ -528,7 +528,7 @@ static int condition_test_firmware_smbios_field(const char *expression) {
         delete_trailing_chars(field, WHITESPACE);
 
         /* Parse operator */
-        operator = parse_compare_operator(&expression, COMPARE_ALLOW_FNMATCH);
+        operator = parse_compare_operator(&expression, COMPARE_ALLOW_FNMATCH|COMPARE_EQUAL_BY_STRING);
         if (operator < 0)
                 return operator;