From: pavel.filipensky <pavel.filipensky@gmail.com>
Date: Fri, 16 Apr 2021 12:24:15 +0000 (+0200)
Subject: s3:passdb: Fix 'return 1' in secrets_store_creds()
X-Git-Tag: tevent-0.11.0~1076
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=667fd04ccd500bc6b5f619450b577f62d8a234ab;p=thirdparty%2Fsamba.git

s3:passdb: Fix 'return 1' in secrets_store_creds()

The recently introduced function secrets_store_creds() should always
use 'return false' in case of a failure. It is not only spelling issue
since 'return 1' actually means 'return true'.

Signed-off-by: Pavel Filipensky <pavel.filipensky@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>

Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Tue Apr 20 06:42:50 UTC 2021 on sn-devel-184
---

diff --git a/source3/passdb/secrets.c b/source3/passdb/secrets.c
index be9cc0039d3..fdacafa11c9 100644
--- a/source3/passdb/secrets.c
+++ b/source3/passdb/secrets.c
@@ -169,7 +169,7 @@ bool secrets_store_creds(struct cli_credentials *creds)
 	ok = secrets_store(SECRETS_AUTH_DOMAIN, p, strlen(p) + 1);
 	if (!ok) {
 		DBG_ERR("Failed storing auth domain name\n");
-		return 1;
+		return false;
 	}