From: Alexander Bainbridge-Sedivy <alex.bainbridge@inkbridge.io>
Date: Wed, 15 Jul 2026 20:46:36 +0000 (-0400)
Subject: lib/server/virtual_servers: clear fr_value_box on error paths in define_server_values... 
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=66f7c8bb2da9f6318ab59810d9268ae250ec3aef;p=thirdparty%2Ffreeradius-server.git

lib/server/virtual_servers: clear fr_value_box on error paths in define_server_values (leak)
---

diff --git a/src/lib/server/virtual_servers.c b/src/lib/server/virtual_servers.c
index 3c2808ef0d9..3d4082d0aad 100644
--- a/src/lib/server/virtual_servers.c
+++ b/src/lib/server/virtual_servers.c
@@ -1684,11 +1684,13 @@ static int define_server_values(CONF_SECTION *cs, fr_dict_attr_t *parent)
 
 		if (slen != len) {
 			cf_log_err(cp, "Unexpected text after value");
+			fr_value_box_clear(&box);
 			return -1;
 		}
 
 		if (fr_dict_enum_add_name(UNCONST(fr_dict_attr_t *, da), attr, &box, false, false) < 0) {
 			cf_log_err(cp, "Failed adding value - %s", fr_strerror());
+			fr_value_box_clear(&box);
 			return -1;
 		}