From: Ondřej Surý <ondrej@isc.org>
Date: Fri, 24 Mar 2023 11:20:07 +0000 (+0100)
Subject: Re-add the comment to streamdns_readmore()
X-Git-Tag: v9.19.12~51^2~5
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=670df3da74c9da75238298ef35a528c6d0e30873;p=thirdparty%2Fbind9.git

Re-add the comment to streamdns_readmore()

Put the comment back, so it's more obvious that we are only restarting
timer when there's a last handle attached to the socket; there has to be
always at least one.
---

diff --git a/lib/isc/netmgr/streamdns.c b/lib/isc/netmgr/streamdns.c
index 2b3c8c38b96..a34e46d3e6c 100644
--- a/lib/isc/netmgr/streamdns.c
+++ b/lib/isc/netmgr/streamdns.c
@@ -103,8 +103,10 @@ static void
 streamdns_readmore(isc_nmsocket_t *sock, isc_nmhandle_t *transphandle) {
 	streamdns_resumeread(sock, transphandle);
 
+	/* Restart the timer only if there's a last single active handle */
 	isc_nmhandle_t *handle = ISC_LIST_HEAD(sock->active_handles);
-	if (handle != NULL && ISC_LIST_NEXT(handle, active_link) == NULL) {
+	INSIST(handle != NULL);
+	if (ISC_LIST_NEXT(handle, active_link) == NULL) {
 		isc__nmsocket_timer_start(sock);
 	}
 }